-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer to smtp_config by ID #185
Conversation
- Update Zitadel provider - Update the smtp_config resource to work with the ID
The test currently fails as follows:
I'm not sure how to proceed. There is probably no default SMTP config anymore, so to import a default SMTP config, one would have to be created beforehand. Is this the correct assumption and how to do that? |
For reference: Via Discord Migual A. C suggested that this resource should also activate the SMTP configuration:
However, I don't believe that this is a good idea:
There could also be an
|
HI @cimnine, I took the liberty and included this changes in the new v2.0.0 release, as it was necessary to include it to upgrade zitadel/zitadel-go dependency to v3. |
I can't check, as I run into #195 when trying. |
@stebenz I believe the resource's documentation is wrong for the import:
But other than that, it works for me. |
This updates the terraform provider to refer to the SMTP Configuration by their IDs. This is a breaking change! Previous SMTP configs need to be removed from the state and re-imported with their proper resource ID.
Fixes #180
Todo
Definition of Ready